Differentiate unset value from null value in OpenApiSchema.Const#2936
Merged
Conversation
Youssef1313
marked this pull request as ready for review
July 14, 2026 07:40
Member
Author
|
Benchmark is reporting a perf regression. @baywet I assume it's because we are introducing a new field (bool) to the objects which is increasing the object size? Should it be fine? |
baywet
previously approved these changes
Jul 14, 2026
baywet
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! Would you mind updating the performance reports please?
Member
Author
|
@copilot Can you update the performance report? |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
baywet
approved these changes
Jul 14, 2026
baywet
added a commit
that referenced
this pull request
Jul 14, 2026
fix: differentiate unset value from null value in OpenApiSchema.Const (#2936)
This was referenced Jul 15, 2026
Merged
github-actions Bot
pushed a commit
to psmfd/agent-expertise-api
that referenced
this pull request
Jul 20, 2026
Updated [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) from 2.10.0 to 2.11.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.OpenApi's releases](https://github.com/Microsoft/OpenAPI.NET/releases)._ ## 2.11.0 ## [2.11.0](microsoft/OpenAPI.NET@v2.10.0...v2.11.0) (2026-07-15) ### Features * adds support for anchor and id external resolution ([557bd6a](microsoft/OpenAPI.NET@557bd6a)) * adds support for anchor and id external resolution ([4138e47](microsoft/OpenAPI.NET@4138e47)) * **schema:** resolve bare $dynamicRef via $dynamicAnchor index ([#2913](microsoft/OpenAPI.NET#2913)) ([baf8428](microsoft/OpenAPI.NET@baf8428)) * **schema:** resolve bare $dynamicRef via $dynamicAnchor index ([#2913](microsoft/OpenAPI.NET#2913)) ([a139f83](microsoft/OpenAPI.NET@a139f83)) * support relative URI resolution in $dynamicRef ([#2928](microsoft/OpenAPI.NET#2928)) ([#2945](microsoft/OpenAPI.NET#2945)) ([6091f5a](microsoft/OpenAPI.NET@6091f5a)) * support relative URI resolution in $dynamicRef ([#2928](microsoft/OpenAPI.NET#2928)) ([#2945](microsoft/OpenAPI.NET#2945)) ([a8688dc](microsoft/OpenAPI.NET@a8688dc)) ### Bug Fixes * adds explicit error message for invalid json pointers ([#2955](microsoft/OpenAPI.NET#2955)) ([a304e56](microsoft/OpenAPI.NET@a304e56)) * differentiate unset value from null value in OpenApiSchema.Const ([#2936](microsoft/OpenAPI.NET#2936)) ([a8787af](microsoft/OpenAPI.NET@a8787af)) * differentiate unset value from null value in OpenApiSchema.Const ([#2936](microsoft/OpenAPI.NET#2936)) ([e08570f](microsoft/OpenAPI.NET@e08570f)) * handle nullability more accurately during serialization for 3.0/2.0 ([#2933](microsoft/OpenAPI.NET#2933)) ([bc11356](microsoft/OpenAPI.NET@bc11356)) * handle nullability more accurately during serialization for 3.0/2.0 ([#2933](microsoft/OpenAPI.NET#2933)) ([310b6e2](microsoft/OpenAPI.NET@310b6e2)) Commits viewable in [compare view](microsoft/OpenAPI.NET@v2.10.0...v2.11.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jul 20, 2026
github-actions Bot
pushed a commit
to EelcoLos/nx-tinkering
that referenced
this pull request
Jul 21, 2026
Updated [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) from 2.10.0 to 2.11.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.OpenApi's releases](https://github.com/Microsoft/OpenAPI.NET/releases)._ ## 2.11.0 ## [2.11.0](microsoft/OpenAPI.NET@v2.10.0...v2.11.0) (2026-07-15) ### Features * adds support for anchor and id external resolution ([557bd6a](microsoft/OpenAPI.NET@557bd6a)) * adds support for anchor and id external resolution ([4138e47](microsoft/OpenAPI.NET@4138e47)) * **schema:** resolve bare $dynamicRef via $dynamicAnchor index ([#2913](microsoft/OpenAPI.NET#2913)) ([baf8428](microsoft/OpenAPI.NET@baf8428)) * **schema:** resolve bare $dynamicRef via $dynamicAnchor index ([#2913](microsoft/OpenAPI.NET#2913)) ([a139f83](microsoft/OpenAPI.NET@a139f83)) * support relative URI resolution in $dynamicRef ([#2928](microsoft/OpenAPI.NET#2928)) ([#2945](microsoft/OpenAPI.NET#2945)) ([6091f5a](microsoft/OpenAPI.NET@6091f5a)) * support relative URI resolution in $dynamicRef ([#2928](microsoft/OpenAPI.NET#2928)) ([#2945](microsoft/OpenAPI.NET#2945)) ([a8688dc](microsoft/OpenAPI.NET@a8688dc)) ### Bug Fixes * adds explicit error message for invalid json pointers ([#2955](microsoft/OpenAPI.NET#2955)) ([a304e56](microsoft/OpenAPI.NET@a304e56)) * differentiate unset value from null value in OpenApiSchema.Const ([#2936](microsoft/OpenAPI.NET#2936)) ([a8787af](microsoft/OpenAPI.NET@a8787af)) * differentiate unset value from null value in OpenApiSchema.Const ([#2936](microsoft/OpenAPI.NET#2936)) ([e08570f](microsoft/OpenAPI.NET@e08570f)) * handle nullability more accurately during serialization for 3.0/2.0 ([#2933](microsoft/OpenAPI.NET#2933)) ([bc11356](microsoft/OpenAPI.NET@bc11356)) * handle nullability more accurately during serialization for 3.0/2.0 ([#2933](microsoft/OpenAPI.NET#2933)) ([310b6e2](microsoft/OpenAPI.NET@310b6e2)) Commits viewable in [compare view](microsoft/OpenAPI.NET@v2.10.0...v2.11.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eelco Los <5102501+EelcoLos@users.noreply.github.com>
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2935